-
-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor clone
package
#367
Comments
This issue has had no activity in the past 2 months. Marking as |
Reopening this because the @TwFlem would love to get your input on what you think needs to be done. You mentioned |
@carreter I mentioned the seqhash performance in #393 because the bug fix was related to concurrent code. Before removing it, I did some profiling to make sure it didn't cause any issues. It turns out removing the concurrency was a speedup. I only mentioned improving seqhash just in case if we needed cloning to be faster. Unless Poly consumers are currently raising concerns about performance, I would not say seqhash is fine the way it currently is. |
This is gonna be high-priority for me this January as I will be working to facilitate the cloning workflow of Fabio Caliendo in Prof. Ron Weiss' lab. Currently blocks #359 . |
This issue has had no activity in the past 2 months. Marking as |
Per @Koeng101 's suggestion, the
clone
package needs some refactoring to make its code easier to understand and use.Blocks #359 .
The text was updated successfully, but these errors were encountered: