You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I saw from an earlier issue that it was deemed token refresh is out of scope for this library.
While disappointing, I can get behind the logic but request that the framework then expose hooks so that we can provide token management ourselves.
For example, right now I am subclassing AsyncFHIRClient and overriding _do_request so that I can catch expired tokens and handle refreshing. This isn't ideal since I am dependent on this library's implementation which is subject to change. It would be nice if instead, there were a before_request hook that allows us to mutate request headers and the like accordingly.
BTW, this is by FAR the best implementation of a FHIR client I have come across. While aimed mostly towards Aidbox, it has been working fine with HAPI and is leaps and bounds above the SMART on FHIR client that is somehow advertised excessively.
The text was updated successfully, but these errors were encountered:
I saw from an earlier issue that it was deemed token refresh is out of scope for this library.
While disappointing, I can get behind the logic but request that the framework then expose hooks so that we can provide token management ourselves.
For example, right now I am subclassing
AsyncFHIRClient
and overriding_do_request
so that I can catch expired tokens and handle refreshing. This isn't ideal since I am dependent on this library's implementation which is subject to change. It would be nice if instead, there were abefore_request
hook that allows us to mutate request headers and the like accordingly.BTW, this is by FAR the best implementation of a FHIR client I have come across. While aimed mostly towards Aidbox, it has been working fine with HAPI and is leaps and bounds above the SMART on FHIR client that is somehow advertised excessively.
The text was updated successfully, but these errors were encountered: