Improve Docker Build and Deployment for Multi-Arch Support (arm64) #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- the retag workflow seems to not able to handle multi-arch images properly
holysoles
approved these changes
Sep 18, 2024
There was a problem hiding this comment.
Looks good to me!
Testing evidence that this resolves the issue:
Current state does yield a benign, additional architecture on the packages page named "unknown/unknown", but that is a known behavior and can be removed (with a tradeoff) if the Beeper team cares
Co-authored-by: Patrick Evans <[email protected]>
|
@tulir Sorry to bother you but would you mind merging this pull request? Thank you! 🙏 |
devnoname120
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add multi-arch support for Docker images: The previous implementation did not handle multi-arch correctly. This PR updates the Docker build process to support multiple architectures (linux/amd64 and linux/arm64) using the docker/metadata-action and docker/build-push-action.
Tested the changes on an arm machine and verified the build with the GitHub Container Registry.
Fixes: #25
Additional Note: The
beeper/docker-retag-push-latestaction does not seem to handle multi-arch correctly, which is a separate issue that needs to be addressed.Verification: Please verify the changes by checking the Docker image on the GitHub Container Registry: https://github.com/slikie/bridge-manager/pkgs/container/bridge-manager