Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mbsync: Ask before making any changes #4250

Open
Maxr1998 opened this issue Jan 23, 2022 Discussed in #4247 · 1 comment · May be fixed by #5600
Open

mbsync: Ask before making any changes #4250

Maxr1998 opened this issue Jan 23, 2022 Discussed in #4247 · 1 comment · May be fixed by #5600
Labels
feature features we would like to implement

Comments

@Maxr1998
Copy link
Contributor

Discussed in #4247

Originally posted by Maxr1998 January 23, 2022
When running beet mbsync, the command should print the proposed changes, and then ask for approval, similarly to beet modify.

That's because changes on MusicBrainz may not always be expected or wanted.

Always running the command with -p first, checking the output, and running it again without the flag is tedious (and may even introduce race conditions if something gets edited in between, even if unlikely).

For the old behavior, a -y flag could be introduced, or a configuration file option.

@sampsyo sampsyo added the feature features we would like to implement label Jan 23, 2022
@sampsyo sampsyo changed the title mbsync plugin should ask before making any changes mbsync: Ask before making any changes Jan 23, 2022
@Holzhaus
Copy link
Contributor

IMHO it's not necessary to change the current behavior. We could also just introduce a new --timid flag (similar to import --timid) and keep the current behavior as-is.

@Duncaen Duncaen linked a pull request Jan 16, 2025 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature features we would like to implement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants