No error showed when error threw with --module flag

[zhuscat]

QuickJS Version: 2024-01-13

/* fib module */
export function fib(n)
{
    if (n <= 0)
        return 0;
    else if (n == 1)
        return 1;
    else
        return fib(n - 1) + fib(n - 2);
}

/* example of JS module */

import { fib } from "./fib_module.js";

// here I throw an Error
throw new Error('test error');

console.log("Hello World");
console.log("fib(10)=", fib(10));

When I execute qjs ./examples/hello_module.js, no error showed

[navrocky]

I confirm this error for a version 2024-01-13. After rolling back to version 2023-12-09 the errors started to appear.

I am using the QuickJS API, not the CLI. When I call JS_Eval with a broken script and JS_EVAL_TYPE_GLOBAL flag then it returns JS exception (it's normal):

JS_Eval(ctx, script.c_str(), script.size(), file.c_str(), JS_EVAL_TYPE_GLOBAL);

But if I use the JS_EVAL_TYPE_MODULE flag then JS_Eval silently terminates without any errors or exceptions and returns JSValue with JS_TAG_MODULE:

JS_Eval(ctx, script.c_str(), script.size(), file.c_str(), JS_EVAL_TYPE_MODULE);

Logging insertions into the script shows that execution flow aborted right at the point of the error.

In version 2023-12-09 everything works with modules as expected.

[bnoordhuis]

Does it work when you pass the JS_Eval result to JS_EvalFunction? And in turn pass that result to js_std_await?

I didn't test with the code from this repo but in quickjs-ng it works as expected.

[XuJiandong]

a very minimal reproducible case:

❯ cat throw.mjs

throw "hi";

❯ qjs throw.mjs; echo $?
0

[saghul]

The CLI won't exit with an error in async functions. We fixed that in NG: quickjs-ng/quickjs#514