Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buggy game #252

Closed
benckx opened this issue Dec 15, 2024 · 3 comments
Closed

buggy game #252

benckx opened this issue Dec 15, 2024 · 3 comments
Assignees
Labels
bug Something isn't working feature PVP Relating to games between human players

Comments

@benckx
Copy link
Owner

benckx commented Dec 15, 2024

something seems wrong with this game
https://elephantchess.io/game?id=EYI11Ad81jKv

@benckx benckx self-assigned this Dec 15, 2024
@benckx benckx converted this from a draft issue Dec 15, 2024
@benckx benckx added bug Something isn't working feature PVP Relating to games between human players labels Dec 15, 2024
@benckx
Copy link
Owner Author

benckx commented Dec 15, 2024

Added checks on playing move so illegal moves won't be saved to db and results in error. There were already some checks but they were not sufficient.

Also added a flag on game table, so games with errors can be filtered out.

It is unclear why some illegal moves where inserted in the history (and some more moves afterward). I suspect some moves got registered properly in the UI but were not sent to the back end, resulting in de-synchronization between UI and backend.

@benckx benckx closed this as completed Dec 15, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in elephantchess.io roadmap Dec 15, 2024
@benckx benckx reopened this Dec 15, 2024
@benckx benckx moved this from Done to In Progress in elephantchess.io roadmap Dec 15, 2024
@benckx
Copy link
Owner Author

benckx commented Dec 15, 2024

Keeping the ticket open because it would be interesting to test all existing games in the db and flag them. Also filter them out from all lists (user data, etc.)

@benckx benckx moved this from In Progress to Todo in elephantchess.io roadmap Dec 23, 2024
@benckx benckx moved this from Todo to In Progress in elephantchess.io roadmap Dec 27, 2024
@benckx
Copy link
Owner Author

benckx commented Dec 27, 2024

Found only 1 other such case

@benckx benckx pinned this issue Dec 27, 2024
@benckx benckx closed this as completed Dec 27, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in elephantchess.io roadmap Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feature PVP Relating to games between human players
Projects
Development

No branches or pull requests

1 participant