New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support PhantomJS 2.0 #34

Open

otakustay opened this issue May 11, 2015 · 1 comment

Labels

otakustay commented May 11, 2015

Since PhantomJS 2.0 deprecated the phantom.args property, we should use system.args instead

Sorry for not able to open a pull request currently, we should just change the currentUrl assignment to:

currentUrl = phantom.args ? phantom.args[ 0 ] : require( 'system' ).args[ 1 ],

The text was updated successfully, but these errors were encountered:

gregpabian added the enhancement label

Collaborator

gregpabian commented May 15, 2015

Thanks for the tip, I'll have a look on that!

gregpabian added a commit that referenced this issue


          Resolved #34 - added support for PhantomJS 2.0

220f097

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment