Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address Claim Byte Order #6

Open
foogly84 opened this issue Sep 1, 2020 · 1 comment
Open

Address Claim Byte Order #6

foogly84 opened this issue Sep 1, 2020 · 1 comment

Comments

@foogly84
Copy link

foogly84 commented Sep 1, 2020

In name.py, your property for bytes reverses the order of the data stored in value, but I believe value is already in the correct byte order for the address claim message. When you use that data in the controller application it creates the incorrect name for the controller.

@foogly84
Copy link
Author

foogly84 commented Sep 3, 2020

You test_ca is also broken, and is accepting values that are out of range.

test_addr_claim_fixed calls for vehicle_system to be 155, but it has a max of 127 based on the number of bits available for this number.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant