New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contributing & Releases ;) #34

Closed

benmarten opened this issue Jan 13, 2018 · 1 comment

Owner

benmarten commented Jan 13, 2018

Hi @barryvdh! I saw you pushed some commits directly to master. Unfortunately I had to revert them, pushing a new release...

I generally follow the git flow practice for this repo. Hence all new commit should go to the develop branch first. Then for a new release I follow this: https://github.com/benmarten/CryptoETF/blob/develop/README.md#releasing

This will create nice tags, and once the commit messages are in the conventional changeling style (https://www.npmjs.com/package/conventional-changelog-cli), they will show up nicely in the CHANGELOG: https://github.com/benmarten/CryptoETF/blob/master/CHANGELOG.md done via: https://github.com/benmarten/CryptoETF/blob/master/package.json#L30

So please feel free to commit your fixes again to develop. Unfortunately I lost them, after I realized they were in master.... Sorry about that ;)

benmarten closed this as completed

Collaborator

barryvdh commented Jan 13, 2018

So does everything need to be a new tag?

I cant reproduce the color bug, but I've re-did the PR for Binance in #35

I'll leave it up to you to tag/merge them then ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment