Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add use_github_action #132

Open
annakrystalli opened this issue Jul 2, 2020 · 5 comments
Open

Add use_github_action #132

annakrystalli opened this issue Jul 2, 2020 · 5 comments

Comments

@annakrystalli
Copy link
Contributor

annakrystalli commented Jul 2, 2020

Please wait for some discussion of your request before making a Pull Request.

Is your feature request related to a problem? Please describe.

Many are using GitHub Actions for CI. For researchers, the ability to test on many systems with a single CI framework and script could lower the barrier to understanding their codes behaviour on different systems.

Describe the solution you'd like

Create a new use_github_action function based on usethis::use_github_action (I believe still only available in devel) (perhaps with a more limited build matrix by default) and translate the Travis build workflow.

** Describe alternatives you've considered**
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@benmarwick
Copy link
Owner

I agree this sounds like a very good idea that we should implement. @annakrystalli would you like to make a PR with an rtools::use_github_action that is in the spirit of our current rtools::use_travis that includes the docker container?

@annakrystalli
Copy link
Contributor Author

I could definitely give it a go!

It might be a couple of weeks till I can get to it though.

@nevrome
Copy link
Collaborator

nevrome commented Jul 3, 2020

Excellent! There is some interesting code in #109 that could serve as an inspiration. I think Github and Gitlab use a similar setup for their CI tools?

@benmarwick
Copy link
Owner

I think this is the way to go. Use of travis and circle is now very uncommon in the R community, with most people adopting GitHub Actions for CI. I've been using GitHub Actions on my research compendia for a while and it's been fine. I propose to remove the functions for using travis and circle from rrtools, and add a function for GitHub Actions. What do you all reckon?

@wolass
Copy link
Contributor

wolass commented Aug 3, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants