Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application silently exits when SSH_AUTH_SOCK file already exists #35

Closed
ferenczy opened this issue Mar 10, 2020 · 2 comments · Fixed by #39
Closed

Application silently exits when SSH_AUTH_SOCK file already exists #35

ferenczy opened this issue Mar 10, 2020 · 2 comments · Fixed by #39

Comments

@ferenczy
Copy link

I just had an issue that I was unable to execute neither wsl-ssh-pageant or wsl-ssh-pageant-gui. Both just exited immediately, without any error message or log file produced. It was quite hard to debug and it took me some time to notice that the SSH_AUTH_SOCK file already existed. Probably some leftover from a previous run. I just deleted the file and it was working again.

It would be good to display some error message in such case to make user's life easier.

@ferenczy ferenczy changed the title Show an error when SSH_AUTH_SOCK file exists Application silently exits when SSH_AUTH_SOCK file already exists Mar 19, 2020
@ferenczy
Copy link
Author

So considering the combination of the fact that it looks like the socket file (SHH_AUTH_SOCK) is being left in place when the application shutdowns and the fact that it doesn't start when the socket already exists, it's not convenient to delete the socket file manually before every start.

Fortunately, there's an option --force which instructs the application to overwrite the socket file while starting as described in #34.

But still, it would be a good UX to inform the user why the application exited in case --force is not used. Ideally both on the console and in case of wsl-ssh-pageant-gui also using a GUI dialog.

@benpye
Copy link
Owner

benpye commented Apr 8, 2020

Thanks for the feedback here - I'm gonna mark this as up-for-grabs. I'm happy to approve a PR that can do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants