Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'auto' mode with Karma: suite runs again before completion, on file changes #155

Open
vemv opened this issue Oct 29, 2017 · 2 comments
Open

Comments

@vemv
Copy link

vemv commented Oct 29, 2017

Hi!

I found out that when running e.g. lein doo chrome-headless dev (this is, 'auto' mode), when one touches a file, the test suite will be run again even though the current one may not have finished.

For example, for this never-ending test:

(deftest sample
  (testing "A test that never completes"
    (async done)))

When I leave the test suite running 'forever' (which won't fail given my :doo {:paths {:karma "karma --browserNoActivityTimeout 600000"}} setting), with each file save the suite will be triggered again.

The correct behavior would be to wait till completion, rather than have concurrently-running suites (that's what I think that can happen at times).

I created a repro repo, fortunately with just 1 isolated relevant commit: reducecombine/doo-repro@94d37ef

Dunno if I'm the first to notice this. I reckon that without browserNoActivityTimeout the issue is harder to notice. I need that setting for performing Selenium-like tests.

Cheers - Victor

@vemv
Copy link
Author

vemv commented Oct 30, 2017

Btw when I close a long auto testing session I can read this:

Close Karma run
Close Karma run
Close Karma run
Close Karma run
Close Karma run
Close Karma run
Close Karma run
Close Karma run
Close Karma run
Close Karma run
Close Karma run
Shutdown Karma Server
Close Karma run
Close Karma run
Close Karma run

@metametadata
Copy link

I see the same problem: there're numerous Karma "run"s created and their log outputs interleave.

Also often the whole "lein doo" process fails after several runs, maybe it can be related.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants