Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: K8s-sidecar sometimes misses deletion of an input manifest secret #587

Closed
MiroslavRepka opened this issue Feb 17, 2023 · 3 comments · Fixed by #792
Closed

Bug: K8s-sidecar sometimes misses deletion of an input manifest secret #587

MiroslavRepka opened this issue Feb 17, 2023 · 3 comments · Fixed by #792
Assignees
@MiroslavRepka
Labels
bug Something isn't working good first issue Good for newcomers groomed Task that everybody agrees to pass the gatekeeper

Comments

@MiroslavRepka
Copy link
Contributor

Current Behaviour

Sometimes, the k8s-sidecar attached to the frontend, misses the deletion of a secret containing an input manifest. This causes a huge issue since if users will delete the secret, and k8s-sidecar misses it, they do not have any other way to interact with the claudie for that input manifest.

Expected Behaviour

The k8s-sidecar should not miss any updates regarding the input manifest secret.

Steps To Reproduce

  1. Deploy a Claudie
  2. Apply an input manifest
  3. Delete the input manifest

(Some repetition of steps 2. and 3. might be needed)

Anything else to note
@MiroslavRepka MiroslavRepka added the bug Something isn't working label Feb 17, 2023
@MarioUhrik
Copy link
Contributor

Are we sure that it's the k8s-sidecar to blame?
Do we have sufficient proof of this ?

@MiroslavRepka
Copy link
Contributor Author

The last time this happened to me, I checked the logs of the sidecar, there was no indication it recognized the secret deletion. Might be some misconfiguration of the sidecar, I am not sure. In any way, this issue aims to resolve it.

@bernardhalas bernardhalas added good first issue Good for newcomers groomed Task that everybody agrees to pass the gatekeeper labels Feb 17, 2023
@MiroslavRepka MiroslavRepka self-assigned this Apr 28, 2023
@MiroslavRepka
Copy link
Contributor Author

Might be related?
kiwigrid/k8s-sidecar#267

@MiroslavRepka MiroslavRepka removed their assignment May 9, 2023
@MiroslavRepka MiroslavRepka mentioned this issue May 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MiroslavRepka MiroslavRepka

Labels
bug Something isn't working good first issue Good for newcomers groomed Task that everybody agrees to pass the gatekeeper
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feat/remove sidecar berops/claudie
3 participants
@bernardhalas @MiroslavRepka @MarioUhrik