From 589138d25cbb115d66e0a0a63a76b9f53a4736b5 Mon Sep 17 00:00:00 2001
From: sunnavy <sunnavy@bestpractical.com>
Date: Tue, 6 Feb 2024 10:52:59 -0500
Subject: [PATCH] Support indeterminate state for boolean(checkbox) cfs

Both checked/unchecked states update boolean custom fields, so we need an
indeterminate state to do nothing for pages like bulk update page.
---
 share/html/Elements/EditCustomFieldSelect | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/share/html/Elements/EditCustomFieldSelect b/share/html/Elements/EditCustomFieldSelect
index 8559c2ea4ac..005c5c68192 100644
--- a/share/html/Elements/EditCustomFieldSelect
+++ b/share/html/Elements/EditCustomFieldSelect
@@ -87,7 +87,11 @@
   <div class="custom-control custom-checkbox">
     <input id="<% $name . '-Display' %>" type="checkbox" class="custom-control-input" data-checked-value="<% $TrueValue %>" data-unchecked-value="<% $FalseValue %>" value-target="#<% $name %>" <% $isChecked ? "checked" : "" %> />
     <label class="custom-control-label" for="<% $name . '-Display' %>"></label>
-    <input type="hidden" id="<% $name %>" name="<% $name %>" class="custom-control" value="<% $isChecked ? $TrueValue : $FalseValue %>" />
+    <input type="hidden" id="<% $name %>" name="<% $name %>" class="custom-control"
+%   if ( !$ARGS{ShowEmptyOption} ) {
+      value="<% $isChecked ? $TrueValue : $FalseValue %>"
+%   }
+    />
   </div>
 <script type="text/javascript">
     var id = <% $name |n,j %>;
@@ -95,7 +99,12 @@
     jQuery('#' + id + '-Display').change(function() {
         var target = jQuery(this).attr('id').replace(/-Display$/, '').replace(/:/g,'\\:');
         jQuery('#' + target).val(jQuery(this).is(':checked') ? jQuery(this).data('checked-value') : jQuery(this).data('unchecked-value'));
+        jQuery('#' + target).prop('disabled', false);
     });
+%# Show indeterminate status for pages like bulk update to not update values by default.
+% if ( $ARGS{ShowEmptyOption} ) {
+    jQuery('#' + id + '-Display').prop ('indeterminate', true);
+% }
 </script>
 % } else {
 % if (@category) {