5.0/cleanup lifecycles #385
Conversation
Here we just clean up obvious errors like nonexistent lifecycles, statuses, etc. This is initially to sync __maps__ when statuses are deleted from lifecycles.
This is initially to fix broken lifecycle links because the URL with Name=... doesn't retain the trailing space.
When admins update configs from web UI, the default values of inputs fully contain current config values, so there is no need to merge old values after update. By not merging old values, admins now are able to delete keys from hash configs. This is initially to support lifecycle deletions.
This gives admins hints of the issue of %Lifecycles configuration.
This is initially to get rid of server errors for our tests that contain other unsupported types(e.g. "racecar" type in "t/lifecycles/utils.pl").
There was a problem hiding this comment.
- Need to add a minimum version for List::MoreUtils:
Undefined subroutine &List::MoreUtils::duplicates called at /Users/jbrandt/work/bps/rt/share/html/Admin/Lifecycles/Mappings.html line 103.
-
For the new "Map same names if unset", let's add a gearbox and make it the first menu item.
-
On the advanced page, I created some invalid JSON and clicked Validate Mappings and got the below. 2 possible fixes: 1) Add a validate button like the block above to validate the JSON and 2) eval the JSON call.
error: malformed JSON string, neither tag, array, object, number, string or atom, at character offset 676 (before "},\r\n "Testing ->...") at /Users/jbrandt/perl5/perlbrew/perls/perl-5.20.3/lib/site_perl/5.20.3/JSON.pm line 190.
context:
...
186: $json->$method( $opt->{$method} );
187: }
188: }
189:
190: return $json->decode( $_[0] );
191: }
| unless $lifecycle->{canonical_case}{ lc $status }; | ||
| unless ( $lifecycle->{canonical_case}{ lc $status } ) { | ||
| push @warnings, $current_user->loc( "Nonexistent default [_1] status [_2] in [_3] lifecycle", $state, lc $status, $name ) | ||
| unless $lifecycle->{canonical_case}{ lc $status }; |
There was a problem hiding this comment.
I think we can drop this unless since it's added above?
|
|
||
| for my $status ( @{ ( $lifecycle->{transitions}{$from} ) || [] } ) { | ||
| push @warnings, $current_user->loc( "Nonexistent status [_1] in transitions in [_2] lifecycle", lc $status, $name ) | ||
| unless $lifecycle->{canonical_case}{ lc $status }; | ||
| } | ||
|
|
||
| if ( $args{Cleanup} ) { |
There was a problem hiding this comment.
Maybe add a comment here to indicate the typical thing "Cleanup" will do?
| $m->text_contains('Lifecycle foobar deleted'); | ||
| $m->follow_link_ok( { text => 'Select', url_regex => qr{/Admin/Lifecycles} } ); | ||
| $m->text_lacks( 'foobar', 'foobar is gone' ); | ||
|
|
There was a problem hiding this comment.
Add tests for the leading/trailing space in lifecycle name fix also?
There was a problem hiding this comment.
The lifecycle name was initially " foobar " on create page and has been auto-corrected to "foobar". I'll add a bit more tests to make sure the name is corrected.
No description provided.