-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issues in the Quick Start Guide #1630
Comments
One more tiny issue is https://bevyengine.org/learn/quick-start/getting-started/ecs/ "It often makes sense to break datatypes up in to small pieces to encourage code reuse." I am quite sure that it should be into, not "in to". And on the same page we have "Quick Note: "hello world!" might show up in a different order than it does below. This is because systems run in parallel by default whenever possible." At least in German language this makes not much sense, because a single entity have no order. I assume it is the same in English. Better would be ""hello world!" might show up in a different position than it does below." or "The lines of text might show up in a different order than it does below." |
And at https://bevyengine.org/learn/quick-start/getting-started/plugins/ please replace To use them all you have to do is: by To use them, all you have to do is: |
Note that it would be a good idea to avoid the term "pointers" in https://bevyengine.org/learn/quick-start/getting-started/resources/. I was very confused by that term here, and had to ask AI to clarify: In Bevy, "pointers" in this context does not refer to traditional pointers like those in languages such as C or C++. Instead, it is using the term more loosely to describe access wrappers or references. Explanation:
Why Use These Wrappers?
Clarifying the Term "Pointers":
Corrected Understanding of the Sentence:
This means that |
Awesome, thank you :) |
Actually, I had not really expected a positive reaction to my remarks -- yesterday I already considered closing it myself again. Sometimes original authors of open source projects thinks that what they wrote is just good enough, or they are very lazy and accept no issues, but only perfect pull requests. But providing perfect PRs is difficult, especially for beginners and non native speakers. The official Rust book would need hundreds of small corrections, but unfortunately the original authors don't care much currently. |
Hundreds of small corrections is something that we welcome :) Feel free to PR fixes for these, I agree with virtually all of this feedback. Normally I would ask that these be done in separate PRs to avoid controversial changes bogging down simple ones, but I think in this case these are all fine. The "pointers" bullet point is the only one I would quibble with: an alternate fix there is to call them "smart pointers", with a link to further reading on that term in Rust. Your fix is also an improvement though, and I think superior because it avoids distracting and overwhelming beginners. |
I recently started studying Bevy -- notice that I am not a English native speaker, so perhaps I just misunderstand a few points?
For me the most serious issue is at https://bevyengine.org/learn/quick-start/getting-started/apps/
Even when reading a second time, I have no idea what "docs linked" refers to exactly. Where is the link? What section of the docs? And "we find three fields: world, schedule, and runner." What fields? Fields in a struct? What struct?
A few other, minor issues:
https://bevyengine.org/learn/quick-start/getting-started/setup/
For better flow, I would suggest this text:
First, navigate to a folder where you want to create your new project. Then, run the following command to create a new directory containing our rust executable project, and move into it:
cargo new my_bevy_game
cd my_bevy_game
Now type cargo run to build and execute your project.
The use of run ... run is awkward, and build and rebuild is swapped. Better is
Now type cargo run again. The Bevy dependencies should start building. This will take some time as you are essentially building THE WHOLE engine from scratch. You will only need to do a full build once. Every rebuild after this one will be fast!
The last tiny issue is at https://bevyengine.org/learn/quick-start/getting-started/apps/
For my feeling, the colon after run is wrong, because the sentence continues. And to avoid duplicate "run" terms, we might better use "then execute".
The text was updated successfully, but these errors were encountered: