Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tutorial [i18n] "tips.notifications.makeFactory" is not translated in en #3674

Closed
aand18 opened this issue Sep 3, 2024 · 2 comments
Closed

tutorial [i18n] "tips.notifications.makeFactory" is not translated in en #3674

aand18 opened this issue Sep 3, 2024 · 2 comments
Labels
Bug Something isn't working

Comments

@aand18
Copy link

aand18 commented Sep 3, 2024

Description

In the first mission of the tutorial, the "make factory" translation appears to be missing.

image

Expected Behaviour

"makeFactory" message should be displayed

Actual Behaviour

A notification is displayed [i18n] "tips.notifications.makeFactory" is not translated in en.

Reproduction steps

  1. start mission 1 of the tutorial
  2. place metal extractor(s) and windmill(s) - not sure the exact quantity to trigger the makeFactory message

Other

No response
@aand18 aand18 added the Bug Something isn't working label Sep 3, 2024
@WatchTheFort
Copy link
Member

@Ruwetuin this looks like a problem with how the sound notification widget is passing I18N keys, the entry in tips.json has always been buildFactory, not makeFactory.

@Ruwetuin
Copy link
Member

Ruwetuin commented Sep 5, 2024

fixed in 87b267d

@Ruwetuin Ruwetuin closed this as completed Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Ruwetuin @aand18 @WatchTheFort