Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dolly camera post-mortem review #1758

Open
3 of 9 tasks
sprunk opened this issue Nov 6, 2024 · 1 comment
Open
3 of 9 tasks

Dolly camera post-mortem review #1758

sprunk opened this issue Nov 6, 2024 · 1 comment
Labels
documentation Improvements or additions to documentation Lua API

Comments

@sprunk
Copy link
Collaborator

sprunk commented Nov 6, 2024

Mostly for the Lua API.

  • RunDollyCamera should probably accept the runtime in seconds (not milli)
  • PauseDollyCamera should have a "pause now" argument, perhaps if you pass nil. I assume that's what the current default value of -1 does, if so then just document that in the luadoc.
  • PauseDollyCamera should probably do something about values outside of the 0-1 range. Clamp or reject
  • SetDollyCamera[Look]Curve should have their args documented. What they mean and what format they are in
  • SetDollyCamera[Relative]Mode shouldn't accept magic values 1 and 2. Split it into functions, perhaps make the other existing functions also set mode
  • SetDollyCameraLookPosition should accept floats in addition to ints
  • make SetDollyCameraLookUnit give feedback if given unit is not currently visible (perhaps because it does not exist). Return a bool or something
  • make sure SetDollyCameraLookUnit obeys LoS rules, i.e. stop tracking if the unit goes into fog of war
  • check Maybe fix #1756 #1757.
@sprunk sprunk added documentation Improvements or additions to documentation Lua API labels Nov 6, 2024
@sprunk
Copy link
Collaborator Author

sprunk commented Nov 6, 2024

cc @loveridge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation Lua API
Projects
None yet
Development

No branches or pull requests

1 participant