You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
RunDollyCamera should probably accept the runtime in seconds (not milli)
PauseDollyCamera should have a "pause now" argument, perhaps if you pass nil. I assume that's what the current default value of -1 does, if so then just document that in the luadoc.
PauseDollyCamera should probably do something about values outside of the 0-1 range. Clamp or reject
SetDollyCamera[Look]Curve should have their args documented. What they mean and what format they are in
SetDollyCamera[Relative]Mode shouldn't accept magic values 1 and 2. Split it into functions, perhaps make the other existing functions also set mode
SetDollyCameraLookPosition should accept floats in addition to ints
make SetDollyCameraLookUnit give feedback if given unit is not currently visible (perhaps because it does not exist). Return a bool or something
make sure SetDollyCameraLookUnit obeys LoS rules, i.e. stop tracking if the unit goes into fog of war
Mostly for the Lua API.
RunDollyCamera
should probably accept the runtime in seconds (not milli)PauseDollyCamera
should have a "pause now" argument, perhaps if you passnil
. I assume that's what the current default value of -1 does, if so then just document that in the luadoc.PauseDollyCamera
should probably do something about values outside of the 0-1 range. Clamp or rejectSetDollyCamera[Look]Curve
should have their args documented. What they mean and what format they are inSetDollyCamera[Relative]Mode
shouldn't accept magic values 1 and 2. Split it into functions, perhaps make the other existing functions also set modeSetDollyCameraLookPosition
should accept floats in addition to intsSetDollyCameraLookUnit
give feedback if given unit is not currently visible (perhaps because it does not exist). Return a bool or somethingSetDollyCameraLookUnit
obeys LoS rules, i.e. stop tracking if the unit goes into fog of warThe text was updated successfully, but these errors were encountered: