Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature flag support #835

Closed
JinnyYi opened this issue Oct 11, 2021 · 1 comment
Closed

Add feature flag support #835

JinnyYi opened this issue Oct 11, 2021 · 1 comment
Assignees

Comments

@JinnyYi
Copy link
Contributor

JinnyYi commented Oct 11, 2021

We use go-integration-test to execute integration tests on services. And all services should add integration tests for operations declared in service.toml.

Excepted Behavior

All services should pass integration tests for operations declared in service.toml, including the basic interface tests, uniformized behavior and some characteristics.

Current Behavior

For some features or behavior, not all services are supported. When we make these behaviors mandatory test cases, there are problems with some integration test cases not passing. And non-stop split tests will lead to too much content to test and complex test cases.

Possible Solution

Add feature flag support:

  • Services should declare supported features.
  • go-integration-test run the tests cases according to the features.

Related Issues

@Xuanwo
Copy link
Contributor

Xuanwo commented Oct 12, 2021

This issue will also fix #756 (comment)

@Xuanwo Xuanwo moved this to Backlog in BeyondStorage Oct 18, 2021
@JinnyYi JinnyYi moved this from Backlog to In Design in BeyondStorage Oct 25, 2021
@JinnyYi JinnyYi moved this from In Design to In Progress in BeyondStorage Oct 29, 2021
@Xuanwo Xuanwo closed this as completed Nov 10, 2021
Repository owner moved this from In Progress to Done in BeyondStorage Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants