Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missing number formatting #11

Open
1 task done
sakulstra opened this issue Mar 13, 2024 · 4 comments
Open
1 task done

missing number formatting #11

sakulstra opened this issue Mar 13, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@sakulstra
Copy link
Contributor

sakulstra commented Mar 13, 2024 •
edited
Loading

Non exhaustive list of state / events that should be formatted in a human readable way.

  • _totalSupply should be formatted by asset decimals (example)
@sakulstra sakulstra added the enhancement New feature or request label Mar 13, 2024
@sakulstra sakulstra changed the title number formatting missing number formatting Mar 13, 2024
@MichaelMorami
Copy link

couple of requests:

  1. we spotted a bug in the formatting - the sum in the attachment should be 250k.
    Screenshot 2024-03-17 at 18 33 28

  2. We will appreciate it if you can write next to the formatted number and the original number a parentheses with the decimals of the token, e.g. (18 decimals) or (6 decimals)

sakulstra referenced this issue in bgd-labs/aave-cli Mar 17, 2024
@sakulstra
fix: formatting tweaks
a03ebfd 
https://github.com/bgd-labs/seatbelt-gov-v3/issues/11\#issuecomment-2002535451
@sakulstra
Copy link
Contributor Author

sakulstra commented Mar 17, 2024 •
edited
Loading

@MichaelMorami should be fixed now: 87ae133#diff-aa3d4e9122e087d99d2541df91e0902bf67f5a2e33fc04bd337f77a83f4a6727 - lmk if you need any specific report to be reran after the updates.

The 250.000... issue was due to falling big to "just formatting", when not finding the decimals.
Fixed the issue to find the decimals in this specific case, but also removed the formatting for the cases we don't.

sakulstra referenced this issue in bgd-labs/aave-cli Mar 20, 2024
@sakulstra
fix: some formatting tweaks (#122)
26b01c6 
* fix: formatting tweaks

https://github.com/bgd-labs/seatbelt-gov-v3/issues/11\#issuecomment-2002535451

* fix: add rate formatting

* fix: update tests
@MichaelMorami
Copy link

Possibly an annoying one:
On streams (example) the amount of the deposits are not formatted. It would be nice to have this, but I also understand if you cannot. In the end, it's not super crucial

@sakulstra
Copy link
Contributor Author

@MichaelMorami streams should now display formatted value & the asset distributed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sakulstra @MichaelMorami