send email via 'get in touch' produces text in httpd log

[realsobek]

I am using CentOS 7 x86_64 with centos-release-scl and with JournalTouch 0.4.2.

Steps to reproduce the problem:

• visit http://journaltouch/ and scroll to the bottom
• click on [Get in touch!]; automatic redirection to: http://journaltouch/checkout.php?action=contact&lang=de_DE
• provide email address and some text
• click on [Submit]

tail -f /var/log/httpd24/error_log prints (I cut the date):

[:error] [pid 753] [client 141.14.232.146:33874] PHP Notice:  Undefined variable: users in /opt/rh/httpd24/root/var/www/html/bibliocoll-JournalTouch-0.4.2-0-ga5da414/checkout.php on line 251, referer: http://journaltouch/checkout.php?action=contact&lang=de_DE
[:error] [pid 753] [client 141.14.232.146:33874] PHP Notice:  Undefined variable: users in /opt/rh/httpd24/root/var/www/html/bibliocoll-JournalTouch-0.4.2-0-ga5da414/checkout.php on line 274, referer: http://journaltouch/checkout.php?action=contact&lang=de_DE
[:error] [pid 753] [client 141.14.232.146:33874] PHP Warning:  Invalid argument supplied for foreach() in /opt/rh/httpd24/root/var/www/html/bibliocoll-JournalTouch-0.4.2-0-ga5da414/checkout.php on line 274, referer: http://journaltouch/checkout.php?action=contact&lang=de_DE
[:error] [pid 753] [client 141.14.232.146:33874] PHP Notice:  Undefined index: file in /opt/rh/httpd24/root/var/www/html/bibliocoll-JournalTouch-0.4.2-0-ga5da414/checkout.php on line 336, referer: http://journaltouch/checkout.php?action=contact&lang=de_DE
[:error] [pid 753] [client 141.14.232.146:33874] PHP Warning:  fopen(): Filename cannot be empty in /opt/rh/httpd24/root/var/www/html/bibliocoll-JournalTouch-0.4.2-0-ga5da414/sys/class.CheckoutActions.php on line 37, referer: http://journaltouch/checkout.php?action=contact&lang=de_DE

At first, I thought this is due to missing settings at http://journaltouch/admin/settings.php -- Mailing. But that is not the case.

Maybe the problem is related to #75?

[krugar]

yep, it is related. i've been applying band-aids to something that requires a splint :P

checkout.php could use some refactoring that separates the routing logic from the presentation. i'm commiting another band-aid to develop for now, but this will need some more love down the road.

/edit: i need more ☕ it's related to #73, not #75. and i should have referenced this issue in c654eb4, not #75...