Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mislabeled "sample names" in ISA-Tab templates #106

Open
mikkonie opened this issue Jun 30, 2022 · 0 comments · May be fixed by bihealth/cubi-isa-templates#13
Open

Mislabeled "sample names" in ISA-Tab templates #106

mikkonie opened this issue Jun 30, 2022 · 0 comments · May be fixed by bihealth/cubi-isa-templates#13
Assignees

Comments

@mikkonie
Copy link
Contributor

mikkonie commented Jun 30, 2022

Describe the bug
Our ISA-Tab cookiecutter templates contain the field sample_names to be filled out. However, in reality these are not sample names, but source names. The actual sample names are derived from these with suffixes such as name-N1.

This can be confusing to users, as the source/sample terminology is used inconsistently between templates and the resulting sample sheets.

To Reproduce
See any ISA-Tab template and the sample_names field.

Expected behavior
This should instead be named source_names, or something less abstract if applicable (donor name? patient name?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants