Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0x00 should be escaped something else than 0x01 0x00, in string dictionary #12

Open
arai-a opened this issue May 24, 2019 · 2 comments
Open

0x00 should be escaped something else than 0x01 0x00, in string dictionary #12

arai-a opened this issue May 24, 2019 · 2 comments

Comments

@arai-a
Copy link

arai-a commented May 24, 2019

entries in string dictionary is separated by 0x00, and 0x00 in string is escaped to 0x01 0x00.
this means that 0x00 found in the decompressed data can either be separator or escaped 0x00.
we should use something else than 0x01 0x00, so that there's only one meaning for 0x00.
@Yoric
Copy link

Yoric commented May 24, 2019

Cc @dominiccooney

@arai-a
Copy link
Author

arai-a commented May 24, 2019

simple solution is:

  • 0x00 => 0x01 0x01
  • 0x01 => 0x01 0x02

or something like that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Yoric @arai-a