Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify loading the external dictionary #4

Open
Yoric opened this issue Sep 19, 2018 · 4 comments
Open

Specify loading the external dictionary #4

Yoric opened this issue Sep 19, 2018 · 4 comments

Comments

@Yoric
Copy link
Contributor

Yoric commented Sep 19, 2018

We don't want the VM to need to download stuff, so this has to be done externally, i.e. by DOM.

@dominiccooney
Copy link
Member

In addition to specifying actual fetches, etc. we probably need a preload type for these resources so browsers can start the dictionary and first BinAST fetch in parallel.

@sendilkumarn
Copy link

I think adding a preload is the best way to download the dictionary
But does that mean that each script tag (if there are multiple) would require this attribute and make vm intelligent enough to handle this?

@Yoric
Copy link
Contributor Author

Yoric commented Dec 7, 2018

A few precisions after discussing with Annevk:

  • we don't want same origin policy for dictionaries, as this would prevent us from putting dictionaries on a cdn;
  • we want CORS, as all new features pretty much require CORS.

@Yoric
Copy link
Contributor Author

Yoric commented Dec 7, 2018

I agree that a preload would be nice, but I believe that this should be a HTTP header, which could be returned either with the webpage itself or with the .binjs. This will make it easier for proxies to inject such preloads.

@RReverser, if you're around, what do you think about that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants