Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace libdash pretty printer with shasta? #33

Open
BolunThompson opened this issue Dec 30, 2024 · 2 comments
Open

Replace libdash pretty printer with shasta? #33

BolunThompson opened this issue Dec 30, 2024 · 2 comments

Comments

@BolunThompson
Copy link
Contributor

BolunThompson commented Dec 30, 2024

Would it be possible to merge the libdash and shasta pretty printers? There have been multiple PRs (#31, #32) that have had to be duplicated across shasta, libdash ocaml and libdash python.

The necessary way of doing this would be to remove the libdash python pretty printer, and instead require a pass through shasta, since shasta already needs to be able to print its typed ast.

Referenced here.

@BolunThompson
Copy link
Contributor Author

There’s also #25, which proposes that libdash should return shasta asts, which seems like a sound approach.

@mgree
Copy link
Collaborator

mgree commented Jan 3, 2025

The only blocker here is that I would want to move https://github.com/mgree/smoosh forward at the same time. I'm not sure when I'll have time to push on all of that, but it should be a fast enough change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants