-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The bioboxes validator task should ensure a metric TSV file is generated #205
Comments
Do you use the reference assembly biobox without a reference? I forgot that we originally defined this as being optional. The GAET biobox requires a reference as it compares the two sets of genome annotations. |
I also noticed that we define |
Yes and I think we should leave it optional for evaluating assemblies where you don't have a reference.
Well, the idea was to define the input according to the short read assembly output definition. But I think we are not using it, so I would say we can remove this and maybe also in the output short read assembler interface. |
I think is fine for QUAST but for GAET, it cannot run without a reference. Some tools might be able to generate metrics without a reference, but others will need it. |
I agree. Going further it might be useful to have a list of terms we use, and what they specifically mean. |
We could make the reference in the reference based interface mandatory and introduce a third, reference-free interface. Quast could implement both, GAET just the reference based one. |
When #204 in completed, the bioboxes file validator should check
that the mandatory metrics file is produced by the assembly validator.
The text was updated successfully, but these errors were encountered: