Skip to content
This repository has been archived by the owner on Jun 22, 2018. It is now read-only.

Library changed #1

Open
AnastasiaGrigoro opened this issue Aug 1, 2017 · 2 comments
Open

Library changed #1

AnastasiaGrigoro opened this issue Aug 1, 2017 · 2 comments
Assignees

Comments

@AnastasiaGrigoro
Copy link
Collaborator

AnastasiaGrigoro commented Aug 1, 2017

Things I changed in the library:

  • added the option to decode the header
    Because the kid in our protocol is included in the header of the token, we need to decode the whole token to get the secret and not only the payload. (non-conflicting change)
  • added the event "unauthorized" emitted to server
    For the purposes of keeping logs at the server, I added the "unauthorized" event to be emitted to the server also, and not only to the client.
  • added a message to server and client when the timeout has passed
    Because there was no error message when timeout for authentication has passed, I created one, and I included it to the "unauthorized" events emitted to the server and the client.
@AnastasiaGrigoro AnastasiaGrigoro changed the title Library changed significantly Library changed Aug 2, 2017
@AnastasiaGrigoro
Copy link
Collaborator Author

AnastasiaGrigoro commented Aug 3, 2017

@ranganath135
To authenticate the WebSocket connections, I am using a library by Auth0 called socketio-jwt.
(https://github.com/auth0/socketio-jwt)

In order to make the changes I wanted, I had to fork the library. Here is my forked version: https://github.com/biobright/socketio-jwt

Here is the rebased history of the changes I made:
https://github.com/auth0/socketio-jwt/compare/master...biobright:master

@rmharrison
Copy link

Auth0 has ceased support/maintenance, but there doesn't seem to be a suitable backup in place, see: https://github.com/auth0-community/socketio-jwt/issues/131#issuecomment-330359981

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants