Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message for partner validation #453

Open
oeway opened this issue May 11, 2022 · 2 comments
Open

Improve error message for partner validation #453

oeway opened this issue May 11, 2022 · 2 comments

Comments

@oeway
Copy link
Contributor

oeway commented May 11, 2022

I got an error: "Expected dict type for loaded source, but got: <class 'str'>" for the partner validation CI but no idea where does the error come from: https://github.com/bioimage-io/bioimage-io-resources/runs/6385884221?check_suite_focus=true#step:4:24

Edit: Same here: https://github.com/imjoy-team/bioimage-io-resources/runs/6385989752?check_suite_focus=true#step:4:24

cc @FynnBe

@FynnBe
Copy link
Member

FynnBe commented May 11, 2022

the file path is given as string. the file does not exist though so it is not recognized as a file path and instead loaded as a yaml string. the file name string loaded as yaml remains a string.... thus the 'loaded' rdf is a string now...
I improved the error message in #454
fixed the validation in the imjoy repo here: imjoy-team/bioimage-io-resources#11
and fixed the validation in bioimage-io-resources here: bioimage-io/bioimage-io-resources@5395274

@oeway
Copy link
Contributor Author

oeway commented May 11, 2022

Got it! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants