Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Topic modelling - temporarily fix gensim to 4.1.2 #885

Merged
merged 1 commit into from
Aug 12, 2022

Conversation

PrimozGodec
Copy link
Collaborator

@PrimozGodec PrimozGodec commented Aug 12, 2022

Issue

Temporarily fixes #820 until Gensim provides a solution

Description of changes
  • Fix Gensim to version 4.1.2 - which is the last version where coherence still works
  • Temporarily remove random seed for LSI since it is not compatible with 4.1.2
  • Change the use of buttonClicked signal to be compatible with PyQt6

The first and second changes should be reverted when Gensim fixes CoherenceModel the last one should stay.

Includes
  • Code changes
  • Tests
  • Documentation

@PrimozGodec
Copy link
Collaborator Author

#886 will fix the issue of failing tests. This PR should be rebased when the fix is merged.

@PrimozGodec
Copy link
Collaborator Author

/rebase

@ajdapretnar ajdapretnar merged commit 40401fe into biolab:master Aug 12, 2022
@PrimozGodec PrimozGodec deleted the topic-temp-fix branch March 29, 2023 10:36
@IzaClaro
Copy link

Issue

Temporarily fixes #820 until Gensim provides a solution

Description of changes
  • Fix Gensim to version 4.1.2 - which is the last version where coherence still works
  • Temporarily remove random seed for LSI since it is not compatible with 4.1.2
  • Change the use of buttonClicked signal to be compatible with PyQt6

The first and second changes should be reverted when Gensim fixes CoherenceModel the last one should stay.

Includes
  • Code changes
  • Tests
  • Documentation

Hi! I am having this same problem when using the widget Topic Modelling. I have been reading the discussions about this issue, and came across this solution. Now, please, how do I this:
«* Fix Gensim to version 4.1.2 - which is the last version where coherence still works

  • Temporarily remove random seed for LSI since it is not compatible with 4.1.2
  • Change the use of buttonClicked signal to be compatible with PyQt6»

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Topic Modeling Crash
3 participants