Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concatenate: adjust description in Variable matching or allow matching variables with different roles #6839

Open
wvdvegte opened this issue Jun 25, 2024 · 0 comments
Assignees
Labels
bug report Bug is reported by user, not yet confirmed by the core team

Comments

@wvdvegte
Copy link

What's wrong?
The first option for Variable matching is described as "Treat variables with the same name as the same variable, even if they are computed using different formulae" where it should actually be "Treat variables with the same name and the same role as the same variable, even if they are computed using different formulae".
If inputs have variables with the same name but different roles (e.g. feature in one input and meta in another) they will be renamed and appear in separate columns. A user may not always be interested in upstream assignment (and alignment) of roles. In that case, it can be hard to find out why the variables with the same name are not treated as the same variable. Therefore, either "and the same role" should be added to the option description, or the matching in Concatenate should be tolerant to differences in role and convert all roles to a default (for instance: if the role is different, the matching always results in a meta variable - which can always be adjusted downstream)

What's your environment?

  • Orange version: 3.37
@wvdvegte wvdvegte added the bug report Bug is reported by user, not yet confirmed by the core team label Jun 25, 2024
@janezd janezd self-assigned this Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report Bug is reported by user, not yet confirmed by the core team
Projects
None yet
Development

No branches or pull requests

2 participants