Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Table modifications #6969

Open
4 tasks
borondics opened this issue Dec 24, 2024 · 1 comment
Open
4 tasks

Data Table modifications #6969

borondics opened this issue Dec 24, 2024 · 1 comment

Comments

@borondics
Copy link
Member

borondics commented Dec 24, 2024

I think some of the phrasing and behaviour of Data Table could be improved. Since it is a very heavily used widget I think it would be great to do (some) of the following.

What's your use case?

  • The "Variables" section could be renamed to "Visualization", which is more descriptive to me.
  • The Restore Original Order button is active even if instances are in the original order. Deactivating it (similar to the Send Selection button behaviour) would be nice in those cases.
  • The "Send Selection" button changes its text to "Send Automatically" when the checkbox is activated. I think this is confusing. I would simply change the text to "Sending Selection".
  • Deselecting a selected row is not intuitive (needs CTRL-leftclick or CMD-leftclick currently). Could it be changed to simply leftclick?

What's your proposed solution?

If this proposal is accepted (and after #6968 is merged) I can work on these (and also update the documentation again).

Are there any alternative solutions?

No.

@janezd janezd self-assigned this Jan 10, 2025
@janezd
Copy link
Contributor

janezd commented Jan 10, 2025

The section is indeed about Variables, and the button could be disabled.

"Send Automatically" (or another verb instead of Send) is consistent throughout Orange - after long discussion and experiments. "Sending Selection" sounds too much like "sending right now, I'll tell you when it's done". I think we'd prefer to keep it as it is.

As for selection, there are two modes.

  • In some contexts, the user is clicking on selected and unselected rows, without the Cmd/Ctrl modifier. Clicking an unselected row selects it without unselecting other rows. This is common in list view, where the user is expected to select multiple items (if the view allows it).
  • In other contexts, clicking an unselected row selects it, and unselects the rows that were selected before. This is common when the user is more likely to select a single item, for instance in Finder/Explorer/Dolphin-or-whatever.

In the latter case, the user can get the former behavior by pressing Ctrl/Cmd.

Table behaves according to the second model. If clicking a selected row would deselect it, it would be a mixture of both. I don't think there's a Qt setting that does it out of the box, and even if it is, it would be uncommon.

In Finder/Explorer you can unselect all items by clicking into empty space. Ideally, we'd have empty space in a table, but we don't.

@janezd janezd removed their assignment Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants