Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📚 Incorrect documentation for the rule "use-import-extensions" #794

Open
1 task done
kibertoad opened this issue Jul 15, 2024 · 3 comments
Open
1 task done

📚 Incorrect documentation for the rule "use-import-extensions" #794

kibertoad opened this issue Jul 15, 2024 · 3 comments

Comments

@kibertoad
Copy link

Documentation URL

https://biomejs.dev/linter/rules/use-import-extensions/

Description

make sure to enable allowImportingTsExtensions=true in your tsconfig.json.

This seems to be an incorrect statement, as allowImportingTsExtensions no longer is useful due to explicit extension mapping support, and it never was super useful to begin with, as it was blocking emission of transpiled code, so referring to it is more confusing than helpful.

Rule does not yet check filesystem for file type. It tries to guess which extension it should add based on the file extension of the current file and the import path.

Caveat seems both redundant and also confusing, having in mind that "Options" section explains both the default and the option to provide mapping manually, while caveat only refers to the default behaviour.

Expectations

Documentation doesn't contain redundant or confusing descriptions.

Code of Conduct

  • I agree to follow Biome's Code of Conduct
@Conaclos
Copy link
Member

due to explicit extension mapping support.

Have you some link to share about this? I am not aware of this change.

@kibertoad
Copy link
Author

@Conaclos I mean biomejs/biome#3274

@Conaclos
Copy link
Member

Oh, I got it. I thought you was talking about TSC.

@Conaclos Conaclos added the enhancement New feature or request label Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants