Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More flexibility for loggers interface #5

Open
andig opened this issue Dec 25, 2018 · 0 comments
Open

More flexibility for loggers interface #5

andig opened this issue Dec 25, 2018 · 0 comments

Comments

@andig
Copy link

andig commented Dec 25, 2018

Looking at logrus it would be helpful if a Contextual's WithFields would again be Contextual. Otherwise chaining fields like e.g. module name and individual log entry fields becomes quite monotonous if in this example the module name cannot be initialized once instead of per log entry.

It would also be nice if WithFields accepted a single map-like interface instead of arrays to allow for

contextualLogger.WithFields(map[string]interface{}{
	"event": name,
	"value": payload,
}).Error("float conversion error, skipping")
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant