Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Global options panel #27

Open
neonfuz opened this issue Jul 28, 2022 · 4 comments
Open

Global options panel #27

neonfuz opened this issue Jul 28, 2022 · 4 comments
Assignees
@neonfuz
Labels
enhancement New feature or request

Comments

@neonfuz
Copy link
Collaborator

neonfuz commented Jul 28, 2022 •
edited
Loading

Move all global configuration into a single panel.

Options will include:

  • Piano key size
  • Piano key labels / coloring
  • Knob firefox drift fix
  • Instrument randomize button
@neonfuz neonfuz self-assigned this Jul 28, 2022
@neonfuz neonfuz added the enhancement New feature or request label Jul 28, 2022
@neonfuz
Copy link
Collaborator Author

neonfuz commented Jul 28, 2022

Some thoughts on how to achieve this, I have 3 so far:

  • using svelte-knobby. This would be easy and quick, but would not be good long term because the UI is not customizable iirc
  • investigate using svelte-portal
  • manually make global options panel & store

@44100hertz
Copy link
Collaborator

Is this still needed for 0.1? I think the titlebar is good enough for now.

@neonfuz
Copy link
Collaborator Author

neonfuz commented Aug 22, 2022

I think it will be good to have some of these options eventually but I guess lets just push this to either 0.2 or backburner, your choice.

@neonfuz
Copy link
Collaborator Author

neonfuz commented Aug 22, 2022

ehh, I'm just throwing it into future version because I think it's somewhat important.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@neonfuz neonfuz

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@neonfuz @44100hertz