BUG: Piano: keys getting stuck

[neonfuz]

Usually when I hit at least 3 keys together, at least one gets stuck playing on chrome

To reproduce:

• Open site in chrom{e,ium}
• Spam keys (press 3+ keys together)

Types of stuck notes fixed:

• Hold key and click
• Events dropped before audio worklet initialized
• key held while input focused
• multi touching a single key
• Firefox sticks on single tap on page load (from hack initialize?)
• Firefox sticks on double tap gesture spam around key
• alt-tab, console, etc (fixable by pressing key again, maybe wontfix)

[neonfuz]

Found a method to get keys stuck on firefox:

• press and hold a note on physical keyboard
• click any other key
• when everything is released, the first note will continue to play

@44100hertz

[neonfuz]

I haven't been able to reproduce keys sticking on the latest prod

[neonfuz]

OK so I can still get keys stuck but it's a bit hard to say how to reproduce. I got keys stuck when my computer was lagging a bit, makes me think it may be related to a race condition, possibly key release before the keydown is done processing somehow?

Also, holding a key and alt-tabbing, or clicking a different tab gets keys stuck.

[44100hertz]

Remaining problems:

1. Alt tab, opening console, etc. causes problems.
2. Should add a panic button to just stop all playing notes for cases that can't be helped.

[neonfuz]

Another way to get keys stuck: it's pretty easy to get one stuck as the audio worklet is firing up. I think instead of dropping key events we need to queue them up, or at least not fire events that will leave the chip in an inconsistent state.

[neonfuz]

And another: hold a key and click a knob to focus the input.

[neonfuz]

All documented ways of getting the stuck knob have been fixed besides wontfix issues.

[neonfuz]

Testing showed firefox mobile still gets stuck on pressing one key after loading.

Also oxygen os triple touch gestures seemed to interfere with pointerup events

[44100hertz]

The octave selector is now sort of a panic button. This can be put on backburner.

[neonfuz]

Maybe we should name it "silence" instead of panic

[neonfuz]

Moving this to 0.2, we should fix firefox touch for that release.