Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if Include folders/files do exists (in case they are removed) #1586

Open
buhtz opened this issue Dec 13, 2023 · 3 comments
Open

Check if Include folders/files do exists (in case they are removed) #1586

buhtz opened this issue Dec 13, 2023 · 3 comments
Assignees
Labels
Discussion decision or consensus needed Feature requests a new feature Medium

Comments

@buhtz
Copy link
Member

buhtz commented Dec 13, 2023

I accidentally missed a part of a backup for over one year. It is my fault. But I think it would have helped me if BIT would warn about such situations.

The folders A and B where in the Include list of my snapshot profile. And snapshots are done as scheduled.
I renamed the folder B to C.
But I forgot to modify the snapshot profile adapting this situation. Because of that C was not part of the snapshot.

I am not sure how to fix it. Maybe a) when opening a profile (in GUI and CLI) or b) when start taking a snapshot the include list should be checked of existence first and warn about missings.

@buhtz buhtz added Feature requests a new feature Discussion decision or consensus needed Low relevant, but not urgent GOOD FIRST ISSUE Used by 24pullrequests.com to suggest issues HELP-WANTED Used by 24pullrequests.com to suggest issues labels Dec 13, 2023
@aryoda
Copy link
Contributor

aryoda commented Dec 13, 2023

how to fix it. Maybe
a) when opening a profile (in GUI and CLI) or
b) when start taking a snapshot the include list should be checked of existence first and warn about missings.

I think both should be done but the thing is the warning is not "pushed" to the user in case of scheduled backups.

Perhaps a permanent systray icon (#1370) with a dedicated icon for existing warnings and errors could be solution for desktop users. Server-only users need log shipping or emails anyhow but should know how to do that.

@buhtz
Copy link
Member Author

buhtz commented Dec 14, 2023

Yeah, the question about how to know about errors in scheduled backups is always in my head. There is an old Issue (#1018) from myself about that and could be a part of the solution.

@buhtz buhtz changed the title Warn about removed Include folders Check if Include folders/files do exists (in case they are removed) Dec 14, 2023
@buhtz buhtz removed the GOOD FIRST ISSUE Used by 24pullrequests.com to suggest issues label Jan 16, 2024
rafaelhdr added a commit to rafaelhdr/backintime that referenced this issue May 9, 2024
Solution b) when start taking a snapshot the include list should be checked of existence first and warn about missings.

reference: bit-team#1586
rafaelhdr added a commit to rafaelhdr/backintime that referenced this issue May 9, 2024
Solution b) when start taking a snapshot the include list should be checked of existence first and warn about missings.

reference: bit-team#1586
@buhtz
Copy link
Member Author

buhtz commented May 9, 2024

We have a first solution in #1718 by Rafel. Have not tested or checked it in details.

  • A log message (to syslog) is created on every snapshot. I think this is the minimum.
  • Also it warns with a message box when a snapshot is triggered manually via the GUI.
  • The systrayicon/notify warning is missing. Don't know how to trigger that for sure.

Other suggestion about a solution? Rafael needs a direction from us.

EDIT: I am undecided about it. Not sure how "urgent" such a situation is for most of our users.

@buhtz buhtz added Medium and removed HELP-WANTED Used by 24pullrequests.com to suggest issues Low relevant, but not urgent labels May 9, 2024
@buhtz buhtz self-assigned this May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discussion decision or consensus needed Feature requests a new feature Medium
Projects
None yet
Development

No branches or pull requests

2 participants