Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test & refactor Config.olderThan() #1791

Closed
buhtz opened this issue Jul 11, 2024 · 0 comments · Fixed by #1877
Closed

test & refactor Config.olderThan() #1791

buhtz opened this issue Jul 11, 2024 · 0 comments · Fixed by #1877
Assignees
Labels
Code Quality About code quality, refactoring, (unit) testing, linting, ... Documentation HELP-WANTED Used by 24pullrequests.com to suggest issues

Comments

@buhtz
Copy link
Member

buhtz commented Jul 11, 2024

Introduction

Welcome to the project. If you pick up this Issue because of the "HELP WANTED" please let us now and introduce your self, your skills and wishes if you are new to the project.

Skills to solve this Issue

  • Unit teststing.
  • Refactoring.

The problem

This is about the method config.py::Config.olderThan().

  • It is not covered by any unit test.
  • It does not belong to the class Config.

Your next steps

  1. If this is your first contribution in this project please introduce
    your self and tell us about your skills, wishes and plans. Also let us
    know how you found the issue and the project.
  2. Read the existing contributors documentation.
  3. We can develop the next steps in the further discussion. Don't hesitate to ask.
  4. See next section Solution.

Solution

  1. First, write unit tests to cover the whole behavior of that method.
  2. Improve the doc strings based on the things you learned about that method.
  3. Move the method somewhere else. If there is no better idea, just move it to common/tools.py as a function.
  4. Refactor the code without changing its behavior.
@buhtz buhtz self-assigned this Jul 11, 2024
@buhtz buhtz added Documentation HELP-WANTED Used by 24pullrequests.com to suggest issues Code Quality About code quality, refactoring, (unit) testing, linting, ... labels Jul 11, 2024
@buhtz buhtz added this to the 2nd release from now milestone Jul 11, 2024
buhtz added a commit that referenced this issue Sep 21, 2024
Extract the method from config.py into tools.py and refactoring it. Improved unit tests.
Related to #1850 (replacing Config class).

Close #1791
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Quality About code quality, refactoring, (unit) testing, linting, ... Documentation HELP-WANTED Used by 24pullrequests.com to suggest issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant