Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Create config struct for simulator #157

Open
carlaKC opened this issue Nov 6, 2023 · 2 comments
Open

Refactor: Create config struct for simulator #157

carlaKC opened this issue Nov 6, 2023 · 2 comments
Labels
Code Health Refactors and improvements to the structure of the code feature New feature or request good first issue Good for newcomers
Milestone

Comments

@carlaKC
Copy link
Contributor

carlaKC commented Nov 6, 2023

  1. Add a SimulationConfig struct that passes all the configuration options to the simulator rather than individual params.
  2. Make log_interval configurable while we're here (currently hard set to 60s)

Started working on this in e929a2d in #141 but decided to leave for a follow up.

@carlaKC carlaKC added feature New feature or request good first issue Good for newcomers Code Health Refactors and improvements to the structure of the code labels Nov 6, 2023
@carlaKC carlaKC added this to the V1 Minor Improvements milestone Nov 6, 2023
@enigbe
Copy link
Collaborator

enigbe commented Jan 30, 2024

@carlaKC I started working on this while waiting for a review. Curious about what should rank higher between CLI arguments and values in a conf file.

I think it would be preferable to have CLI arguments override the conf file if they're passed but happy to code it any other way you'd prefer.

@carlaKC
Copy link
Contributor Author

carlaKC commented Jan 30, 2024

I think it would be preferable to have CLI arguments override the conf file if they're passed but happy to code it any other way you'd prefer.

I think this makes sense, perhaps with a log warning that a config file value has been overwritten?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Health Refactors and improvements to the structure of the code feature New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants