Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Use From<PaymentPreimage> when constructing PaymentHash #172

Open
sr-gi opened this issue Mar 12, 2024 · 3 comments
Open

Refactor: Use From<PaymentPreimage> when constructing PaymentHash #172

sr-gi opened this issue Mar 12, 2024 · 3 comments
Labels
Code Health Refactors and improvements to the structure of the code good first issue Good for newcomers help wanted Extra attention is needed
Milestone
V3

Comments

@sr-gi
Copy link
Member

sr-gi commented Mar 12, 2024

#165 introduces the use of PaymentHash manually building from PaymentPreimage. Recently, LDK added the ability to build the former from the latter into their API: lightningdevkit/rust-lightning#2916.

Update our LDK version and replace the manual construction from the corresponding call when it gets released
@sr-gi sr-gi added feature New feature or request Code Health Refactors and improvements to the structure of the code and removed feature New feature or request labels Mar 12, 2024
@carlaKC carlaKC added good first issue Good for newcomers help wanted Extra attention is needed labels Mar 27, 2024
@carlaKC carlaKC added this to the V3 milestone Mar 27, 2024
@Anyitechs
Copy link

I'll like to work on this issue. Should I go ahead and send a draft PR for it?

cc: @sr-gi @carlaKC

@carlaKC
Copy link
Contributor

carlaKC commented Apr 8, 2024

Should I go ahead and send a draft PR for it?

lightningdevkit/rust-lightning/pull/2916 hasn't landed in a release yet so we should wait for that.

If you'd like something to pick up, we bumped our lightning version but never finished #131 to update the way that we handle feature vectors.

@Anyitechs
Copy link

Should I go ahead and send a draft PR for it?

lightningdevkit/rust-lightning/pull/2916 hasn't landed in a release yet so we should wait for that.

If you'd like something to pick up, we bumped our lightning version but never finished #131 to update the way that we handle feature vectors.

Ok great. I'll jump on that then. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Code Health Refactors and improvements to the structure of the code good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
V3
Development

No branches or pull requests
3 participants
@sr-gi @Anyitechs @carlaKC