Error formatting: Go over the displayed errors and make them more user friendly

[sr-gi]

Just as an example, if a destination node does not support keysend, this is the error we'll be getting:

Error: Lightning Error: ValidationError("Destination node does not support keysend 02ab4734430c485b1d15af93ff00060db86f7fe952b04c19afd42709dcd83b1c50")

Caused by:
    Config validation failed Destination node does not support keysend 02ab4734430c485b1d15af93ff00060db86f7fe952b04c19afd42709dcd83b1c50

[AdamuAbba]

Hey @carlaKC is it fine if I pick this up?

[AdamuAbba]

hey @carlaKC regarding the error messages based on @sr-gi's example above would any of the formats below be acceptable? I'll implement whichever one you pick.

Error: Lightning Error
Caused by:
   Config validation failed Destination node does not support keysend 02ab4734430c485b1d15af93ff00060db86f7fe952b04c19afd42709dcd83b1c50

or do we go with just:

Caused by:
    Config validation failed Destination node does not support keysend 02ab4734430c485b1d15af93ff00060db86f7fe952b04c19afd42709dcd83b1c50

or maybe:

Error: Lightning Error
Type: Validation Error
Caused by: Config validation failed Destination node does not support keysend 02ab4734430c485b1d15af93ff00060db86f7fe952b04c19afd42709dcd83b1c50

we can also consider:

Error: Lightning Error
Type: Validation Error
Caused by: Config validation failed Destination node does not support keysend
Destination: 02ab4734430c485b1d15af93ff00060db86f7fe952b04c19afd42709dcd83b1c50

Standing by for your decision.

[carlaKC]

This one is fine to me, no strong opinions though:

Error: Lightning Error
Caused by:
   Config validation failed Destination node does not support keysend 02ab4734430c485b1d15af93ff00060db86f7fe952b04c19afd42709dcd83b1c50

[AdamuAbba]

Alright got it.

[carlaKC]

One place where we could do better on errors is when we parse our sim file - right now we just display a line an column, not the actual error.

Error: Could not deserialize node connection data or activity description from simulation file (line 41, col 5, err Cannot parse range. Ranges must be strictly increasing (i.e. [x, y] with x > y). Received [20000, 1000] at line 41 column 5).

Example: Missing comma in json

Error: Could not deserialize node connection data or activity description from simulation file (line 38, col 7).

When the actual error contains:

 err expected `,` or `}` at line 38 column 7

Example: Invalid Range

See discussion

Error: Could not deserialize node connection data or activity description from simulation file (line 41, col 5).

vs

Cannot parse range. Ranges must be strictly increasing (i.e. [x, y] with x > y). Received [20000, 1000] at line 41 column 5)

There is ofc a tradeoff between more information for debugging problems and angry-json-screaming, so I think we can look at classify for more nuanced handing of these cases.

[AdamuAbba]

Hey @carlaKC you're right. i'll look into classify and see how we can leverage on it.