Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Add a dockerfile #89

Closed
carlaKC opened this issue Sep 11, 2023 · 8 comments
Closed

Build: Add a dockerfile #89

carlaKC opened this issue Sep 11, 2023 · 8 comments
Milestone

Comments

@carlaKC
Copy link
Contributor

carlaKC commented Sep 11, 2023

No description provided.

@m3dwards
Copy link
Contributor

An image on Docker Hub would also be very useful!

@carlaKC carlaKC added this to the V1 milestone Sep 18, 2023
@Extheoisah
Copy link
Contributor

Can I get clarity on what we want from this?

@carlaKC
Copy link
Contributor Author

carlaKC commented Sep 22, 2023

Can I get clarity on what we want from this?

I started on aDockerfile file here: https://github.com/carlaKC/sim-ln/tree/dockerfile

I think that all we need to add is instructions on how to mount a volume to provide the artifacts the the config file points to. Feel free to pick up from that branch as a starting point if you're interested!

@carlaKC
Copy link
Contributor Author

carlaKC commented Oct 3, 2023

@maxwedwards do you have any preferences/insights for what would be a convenient way to deal with macaroons/certs etc in the docker context (since the simulator can't just read them from local paths)?

Thinking something along the lines of:

  • Volume with all macaroons/certs in it.
  • Config should expect everything to be in ~/config.

@m3dwards
Copy link
Contributor

m3dwards commented Oct 3, 2023

I'm not sure anything specific needs to be added to the Dockerfile as when running the image couldn't you could mount a volume on any path and then specify that path in the config file?

@carlaKC
Copy link
Contributor Author

carlaKC commented Oct 3, 2023

I'm not sure anything specific needs to be added to the Dockerfile as when running the image couldn't you could mount a volume on any path and then specify that path in the config file?

Yeah not to the image itself, just in our instructions for running with docker. Trying to make writing the config file as painless as possible, because I think paths/IPs generally trip folks up.

@m3dwards
Copy link
Contributor

m3dwards commented Oct 3, 2023

I agree, it often trips me up!

I like your original proposal however not so sure on expecting things to be in a specific folder vs allowing the user to place anywhere. Perhaps just a solid example in the documentation?

@carlaKC
Copy link
Contributor Author

carlaKC commented Oct 11, 2023

Closed by #114.

@carlaKC carlaKC closed this as completed Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants