Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output descriptor with both receiving and change paths #31

Open
louneskmt opened this issue Dec 1, 2023 · 6 comments
Open

Output descriptor with both receiving and change paths #31

louneskmt opened this issue Dec 1, 2023 · 6 comments

Comments

@louneskmt
Copy link

Hey! I am trying to use an output descriptor with both the receiving (0) and change (1) paths, as follow: wpkh([284bbfa8/84h/1h/0h]tpubDCe8CRwGAiQ2r3rdChcB3Fp8v4GVjYJqoyKKwBczxGVNnawaK21p7sWh8oiMRo26wmSEhQqHGPVofX7t9BnGaSZjbED9WwRxMt8UeTjF64S/<0;1>/*). It seems that this library does not support this expression <0;1>? I get a Could not parse descriptor error while it seems to work well with 0 instead of <0;1>. Please let me know if I can be of any help implementing this, or the rationale behind not supporting this.

@louneskmt
Copy link
Author

Oh okay, it is not directly in the specs but seems like an extension. Would be cool to have this anyway though!

@landabaso
Copy link
Member

landabaso commented Dec 10, 2023

I believe this format is specific to Ledger. It's a more compact way to represent internal/external keys, making them easier to display on the device. @bigspider may have more insight into this, especially if it has gained wider adoption.

By the way, this library supports Ledger HWW. You can use standard * descriptors, and they are automatically converted to the Ledger format for use on Ledger devices.

@bigspider
Copy link

The multipath syntax is not (yet?) a standard (albeit already quite widely adopted by many software wallets, I think). There's a PR to add it to descriptors: bitcoin/bitcoin#22838

Ledger's script wallet accounts are based on the wallet policies BIP proposal, also adopted in BitBox02 and Jade, but not yet standardized either.

@louneskmt
Copy link
Author

albeit already quite widely adopted by many software wallets, I think

Yeah, I asked this because I was using an output descriptor from Sparrow for my tests and it is using this multipath syntax.

@landabaso Do you think it would be appropriate to support this syntax in the library, considering its growing adoption?

@louneskmt
Copy link
Author

@landabaso BIP388 has been merged: https://github.com/bitcoin/bips/blob/master/bip-0388.mediawiki#descriptor-derivation

@landabaso
Copy link
Member

I'm currently out of office for a couple of weeks... I'll definitely catch up with this in August. Thanks for the notice @louneskmt .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants