Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility details for Purse.io and bcoin #295

Closed
pinheadmz opened this issue Dec 12, 2019 · 2 comments · Fixed by #303
Closed

Compatibility details for Purse.io and bcoin #295

pinheadmz opened this issue Dec 12, 2019 · 2 comments · Fixed by #303
Assignees
Labels
compatibility Enhancements or bugs for the compatibility matrix

Comments

@pinheadmz
Copy link
Contributor

bcoin (https://github.com/bcoin-org/bcoin, https://bcoin.io/) is the backend full node and wallet used by Purse.io. They could be listed together or separately (or just one or the other). bcoin offers a range of options, but Purse has been configured with specific settings. I'm happy to make a PR to this repo with details but I'm not sure if the services explicitly need to be tested by an OpTech associate?

Here's the quick details:

SegWit:

  • bcoin and Purse support SegWit in all forms: native, nested, send and receive.
  • Purse default receive address is bech32 with option for nested.
  • Change address type is either legacy or bech32 depending on wallet witness setting, Purse always uses bech32 for change.
  • bcoin default wallet type is still legacy until Wallet: Use SegWit by default bcoin-org/bcoin#827 is merged.

RBF:

  • bcoin and Purse reject RBF transactions by default (they do not enter the mempool or wallet until confirmed) meaning they will "show replaced" but not "show original" assuming the replacement is not itself signaling RBF.
  • The wallet by default can not send replaceable transactions or replace RBF transactions.
  • Mempool replacement for the bcoin full node is in review: BIP125: Enable replace-by-fee in mempool bcoin-org/bcoin#811. After merge we'll begin work on adding RBF options to the wallet although RBF will likely remain rejected by Purse, since deposits aren't credited before confirmation anyway.

Screen shots:

Purse -- illustrating bech32 and nested deposit addresses:

Screen Shot 2019-12-12 at 9 08 56 AM
Screen Shot 2019-12-12 at 9 08 17 AM

bcoin -- from our API docs illustrating legacy and SegWit wallet account types with receive, change, and nested addresses:

Screen Shot 2019-12-12 at 9 11 27 AM
Screen Shot 2019-12-12 at 9 12 08 AM

@jnewbery jnewbery added the compatibility Enhancements or bugs for the compatibility matrix label Dec 12, 2019
@bitschmidty
Copy link
Contributor

Hey @pinheadmz ! Thanks for opening this. Would be great to get Purse.io in the matrix.

It is not required that an "Optech" person execute the testing and open the PR. Although usually as part of review, if its easy enough, I test myself too.

We are considering a "libraries" section for the future potentially, but not yet. So Id recommend a PR for Purse and not bcoin for now.

Let me know if you plan to open the Purse Compatibility Matrix PR.

@pinheadmz
Copy link
Contributor Author

@bitschmidty Thanks dude, opened a PR: #303

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility Enhancements or bugs for the compatibility matrix
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants