Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appchannel MTU inconsistent with CRTP max packet size #1445

Open
TheCodeinator opened this issue Dec 20, 2024 · 0 comments
Open

Appchannel MTU inconsistent with CRTP max packet size #1445

TheCodeinator opened this issue Dec 20, 2024 · 0 comments

Comments

@TheCodeinator
Copy link

In https://github.com/bitcraze/crazyflie-firmware/blob/master/src/modules/interface/app_channel.h the maximum MTU of an Appchannel packet is defined as 31 bytes. However both in the cflib client library as well as the crtp firmware implementation the maximum crtp MTU is defined as 30 bytes. Therefore for example using the appchannel API in the cflib to send a packet with exactly 31 bytes of payload size will give an error. In my opinion this is a bug and the appchannel MTU should be reduced to 30 bytes in both firmware and documentation. Am I missing something or is this indeed inconsistent?

Have a nice holiday season

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant