Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#INTERNAL-32] update notification centre components #797

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

[#INTERNAL-32] update notification centre components #797

wants to merge 7 commits into from

Conversation

ArinzeJeffrey-droid
Copy link
Contributor

@ArinzeJeffrey-droid ArinzeJeffrey-droid commented Jul 26, 2023 •
edited
Loading

Fixes #796

📸 Looks like

image

  • git fetch
  • git checkout task/internal-32-update-notification-centre-components`
  • yarn
  • yarn storybook
  • navigate to enter component name component

Check:

  • The appearance matches the design in Zeplin
  • The Zeplin component is correctly linked in storybook
  • The documentation for this component is correct, understandable, and up-to-date.

👾 Code changes

Check:

  • The documentation for this component is correct, understandable, and up-to-date.
  • The component makes good use of CSS custom properties to simplify creating variants (or doesn’t have variants).
  • Everything that should be a variable, is.

@ArinzeJeffrey-droid ArinzeJeffrey-droid self-assigned this Jul 26, 2023
@ArinzeJeffrey-droid ArinzeJeffrey-droid marked this pull request as ready for review July 28, 2023 07:57
planktonic
planktonic reviewed Dec 11, 2023
View reviewed changes
Copy link
Member

@planktonic planktonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ticket for this seems a little under-specified. Perhaps we could take a look in the next sprint planning?

scss/bitstyles/ui/notifications.stories.mdx Outdated Show resolved Hide resolved
@ArinzeJeffrey-droid ArinzeJeffrey-droid force-pushed the task/internal-32-update-notification-centre-components branch from 161dc88 to 66d8f5f Compare March 18, 2024 12:19
@planktonic planktonic changed the title Task/internal 32 update notification centre components [#INTERNAL-32] update notification centre components May 15, 2024
@planktonic planktonic force-pushed the task/internal-32-update-notification-centre-components branch from 42f026e to 8c457dd Compare May 15, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@planktonic planktonic planktonic left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@planktonic planktonic

Labels
Redesign
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Notification Centre components
2 participants
@ArinzeJeffrey-droid @planktonic