Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve new monitor tests #21

Open
mkrivoshein opened this issue Apr 30, 2020 · 1 comment · May be fixed by #22
Open

Improve new monitor tests #21

mkrivoshein opened this issue Apr 30, 2020 · 1 comment · May be fixed by #22

Comments

@mkrivoshein
Copy link

Improve TestCreate method:

  • remove port mapping from HTTP test - HTTP monitor should be created even without port specification
  • add HTTPS test
  • add IMAP test
  • add custom port test
mkrivoshein added a commit to bluestar/uptimerobot that referenced this issue Apr 30, 2020
@mkrivoshein
tests for creating HTTPS, IMAP and custom port monitors
1722966 
Fixes bitfield#21
@mkrivoshein mkrivoshein linked a pull request Apr 30, 2020 that will close this issue
Open
@bitfield
Copy link
Owner

Great work, @mkrivoshein! Thanks a lot! I'll review this ASAP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tests for creating HTTPS, IMAP and custom port monitors bluestar/uptimerobot
2 participants
@bitfield @mkrivoshein