Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SubscribeBook to a Funding Book fUSD #206

Open
3 tasks
djimmo opened this issue Dec 28, 2019 · 2 comments
Open
3 tasks

SubscribeBook to a Funding Book fUSD #206

djimmo opened this issue Dec 28, 2019 · 2 comments

Comments

@djimmo
Copy link

djimmo commented Dec 28, 2019

Issue type

  • [x ] bug
  • missing functionality
  • performance
  • feature request

Brief description

When subscribing to a funding orderbook a different update format is received. For trading pairs it is PRICE, COUNT, AMOUNT but for funding this is RATE, PERIOD, COUNT, AMOUNT (found here https://docs.bitfinex.com/reference#ws-public-books). When using the UpdateWith() or SetWithSnapshot() methods on the Orderbook type the orderbook is filled incorrectly due to this different format.

Steps to reproduce

Try to fill Orderbook of fUSD

Additional Notes:

Is this functionality not yet included in this API, or am I not using it correctly?

kind regards,
Djim

@fshiori
Copy link
Contributor

fshiori commented Dec 31, 2019

Yes, it should be a bug.
I think old API don't support funding, so the SDK still only support old style result.
I fix REST API in #205, but I am not sure WS API used the same function.

@JacobPlaster
Copy link
Contributor

Thanks for the PR @fshiori. I've left a comment and will test/merge once addressed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants
@fshiori @djimmo @JacobPlaster and others