Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WS2Manager swallows socket.open/auth errors #565

Open
1 of 4 tasks
adrian-gierakowski opened this issue Dec 7, 2020 · 0 comments
Open
1 of 4 tasks

WS2Manager swallows socket.open/auth errors #565

adrian-gierakowski opened this issue Dec 7, 2020 · 0 comments

Comments

@adrian-gierakowski
Copy link

Issue type

  • bug
  • missing functionality
  • performance
  • feature request

Brief description

I believe the following 2 errors should be emitted by the WS2Manager instead of just being logged:

ws.open().then(() => {
return debug('socket connection opened')
}).catch((err) => {
debug('error opening socket: %s', err.stack)
})

ws.auth().then(() => {
return debug('socket authenticated')
}).catch((err) => {
debug('error authenticating socket: %s', err.message)
})
})

Steps to reproduce

Start WS2Manager with an invalid url (api.bitfinex.com/ws/2 instead of wss://api.bitfinex.com/ws/2) and try to subscribe to one of the channel (for example call subscribeTicker('tBTCUSD').

Additional Notes:
@adrian-gierakowski adrian-gierakowski changed the title wsManager swallows socket.open/auth errors WS2Manager swallows socket.open/auth errors Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant