Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Security issue: insecure cryptography and dependencies #3666

Open
paulmillr opened this issue Dec 15, 2023 · 1 comment
Open

Security issue: insecure cryptography and dependencies #3666

paulmillr opened this issue Dec 15, 2023 · 1 comment

Comments

@paulmillr
Copy link

bitcore/packages/bitcore-lib/package.json

Line 43 in f778e62

"elliptic": "^6.5.3",

has been long unmaintained; and had a few CVEs. I suggest doing following actions:

  • replace elliptic with audited @noble/curves
  • replace scryptsy with audited @noble/hashes
  • upgrade ethers to v6, which stopped using elliptic
  • remove bn.js, replace with native bigint
@kajoseph
Copy link
Collaborator

Thanks for the suggestions and concern. We're actively looking into and addressing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@paulmillr @kajoseph