This repository has been archived by the owner on Jun 8, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 217
[kraken] Exchange orderbook timestamp parse incorrect! #448
Labels
bug
required-for-xchange-merge
This issue has been identified as needing fixing before the project can be merged with XChange.
Comments
pchertalev
pushed a commit
to dsx-tech/xchange-stream
that referenced
this issue
Nov 27, 2019
@sudo168 Thank you for the issue. I have opend fix PR. |
pchertalev
pushed a commit
to dsx-tech/xchange-stream
that referenced
this issue
Dec 4, 2019
pchertalev
pushed a commit
to dsx-tech/xchange-stream
that referenced
this issue
Dec 4, 2019
badgerwithagun
changed the title
Kraken exchange orderbook timestamp parse incorrect!
[kraken] Exchange orderbook timestamp parse incorrect!
Dec 6, 2019
badgerwithagun
added
bug
required-for-xchange-merge
This issue has been identified as needing fixing before the project can be merged with XChange.
labels
Dec 6, 2019
I am good with this |
badgerwithagun
added a commit
that referenced
this issue
Dec 9, 2019
#448 Kraken exchange orderbook timestamp parse incorrect - fixed
Have we fix this issue? If yes can we close it? |
I believe we can close it because PR is merged |
@badgerwithagun Bump for closing due to merged PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
bug
required-for-xchange-merge
This issue has been identified as needing fixing before the project can be merged with XChange.
The Kraken exchange orderbook timestamp is a seconds format since epoch. So need to multiply 1000. But this logic appear in two places:
One in:
info.bitrich.xchangestream.kraken.KrakenOrderBookUtils
private static long timestampToMs(String timestamp) {
return new BigDecimal(timestamp).multiply(new BigDecimal(1000)).longValue();
}
The other in:
org.knowm.xchange.kraken.KrakenAdapters.adaptOrders(...)
The text was updated successfully, but these errors were encountered: