Skip to content
This repository has been archived by the owner on Jun 8, 2020. It is now read-only.

[kraken] Exchange orderbook timestamp parse incorrect! #448

Open
sudo168 opened this issue Nov 14, 2019 · 5 comments
Open

[kraken] Exchange orderbook timestamp parse incorrect! #448

sudo168 opened this issue Nov 14, 2019 · 5 comments
Labels
bug required-for-xchange-merge This issue has been identified as needing fixing before the project can be merged with XChange.

Comments

@sudo168
Copy link

sudo168 commented Nov 14, 2019

The Kraken exchange orderbook timestamp is a seconds format since epoch. So need to multiply 1000. But this logic appear in two places:

One in:
info.bitrich.xchangestream.kraken.KrakenOrderBookUtils

private static long timestampToMs(String timestamp) {
return new BigDecimal(timestamp).multiply(new BigDecimal(1000)).longValue();
}

The other in:
org.knowm.xchange.kraken.KrakenAdapters.adaptOrders(...)

pchertalev pushed a commit to dsx-tech/xchange-stream that referenced this issue Nov 27, 2019
@pchertalev
Copy link
Contributor

@sudo168 Thank you for the issue. I have opend fix PR.

pchertalev pushed a commit to dsx-tech/xchange-stream that referenced this issue Dec 4, 2019
pchertalev pushed a commit to dsx-tech/xchange-stream that referenced this issue Dec 4, 2019
@badgerwithagun badgerwithagun changed the title Kraken exchange orderbook timestamp parse incorrect! [kraken] Exchange orderbook timestamp parse incorrect! Dec 6, 2019
@badgerwithagun badgerwithagun added bug required-for-xchange-merge This issue has been identified as needing fixing before the project can be merged with XChange. labels Dec 6, 2019
@mdvx
Copy link
Contributor

mdvx commented Dec 6, 2019

I am good with this

badgerwithagun added a commit that referenced this issue Dec 9, 2019
#448 Kraken exchange orderbook timestamp parse incorrect - fixed
@makarid
Copy link
Contributor

makarid commented Dec 30, 2019

Have we fix this issue? If yes can we close it?

@pchertalev
Copy link
Contributor

I believe we can close it because PR is merged

@TSavo
Copy link
Contributor

TSavo commented Feb 28, 2020

@badgerwithagun Bump for closing due to merged PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug required-for-xchange-merge This issue has been identified as needing fixing before the project can be merged with XChange.
Projects
None yet
Development

No branches or pull requests

6 participants